As we all know golf takes a certain degree of dedication, commitment, and willingness to put in the time and effort to improve. However, the vast majority of golfers won't do that.
From the players and instructors I have observed and spoken to over the years I believe you have just about nailed it Sean. A general lack of effort from both the players and instructors – thankfully there are a few noticeable exceptions but don’t expect much to change anytime soon.
Given the attitude and life styles of many of the younger generations (drugs, obesity, apathy etc) should we be surprised if it does not improve?
It's kind of sad, really. Of course, there are those who have no inclination to improve and they are out on the course to hang out with friends, smoke a cigar, and have a beer or two. And, that's okay.
Then there are those who complain all the time at not getting better but don't do anything it.